Core Data: Fix ESLint warnings for the hooks directory

[Mamaduka]

What?

PR fixes ESLint warning for Code Data hooks.

Why?

Ideally, the project should not have any ESLint errors and warnings.

How?

npm run lint:js -- packages/core-data/src/hooks --fix

Testing Instructions

Running following lint command should return warnings

npm run lint:js -- packages/core-data/src/hooks

Screenshots or screencast

[github-actions]

Flaky tests detected in 3b25b6b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4111109144
📝 Reported issues:

• [Flaky Test] List #47632 in specs/editor/blocks/query.test.js
• [Flaky Test] should open a preview window for a new post #35387 in /test/e2e/specs/editor/various/preview.spec.js
• [Flaky Test] shouldn't conflict with server-side autosave #35176 in specs/editor/various/autosave.test.js

[gziolo]

Thank you for the fix.

Would it be a good idea to promote this warning to an error? People fix those warnings anyway, so why not enforce that on PR authors?

[Mamaduka]

That makes sense and will match PHPCS standards.

You'll have to commit extra changes when working in the files with warnings. I think most of us have "format on save" enabled in the editors.

We can fix the remaining warning in a single go and add the commit to the .git-blame-ignore-revs.

[gziolo]

You'll have to commit extra changes when working in the files with warnings. I think most of us have "format on save" enabled in the editors.

I think it requires running npm run lint -- --fix (plus the name of the rule that signals violations) because Prettier doesn't format code comments.

[Mamaduka]

The ESLint extensions does, at least in VSCode.

[tyxla]

As initially brought up by @gziolo I'm suggesting that we change the jsdoc/check-line-alignment to error in #47878.