NavigatorButton: Reuse Button types

[ciampo]

What?

Part of #35744

Following up #46997 , this PR cleans up types in NavigatorButton by re-using types from the Button component

Why?

Clean up duplicated code

How?

Button's types are complex, since the component can render as a <button /> or as a <a /> depending on which props are passed.

Since NavigatorButton uses Button with the assumption that it renders a <button /> (and never a <a />), I decided to export a ButtonPropsAsButton type and reuse it in NavigatorButton.

Testing Instructions

There aren't any runtime changes, so everything should work as before if the project builds without TS errors.

[ciampo]

For now I went with the simplest / laziest approach, but here's a few more considerations.

When working on NavigatorButton, we decided to use Button (instead of a vanilla HTML <button />) as the underlying component, for visual coherency. We also made the component polymorphic, in case consumers wanted to BYOB(utton).

On one hand, it feels correct that we advertise all of ButtonPropsAsButton props for the NavigatorButton component, so that consumers can leverage all of Button's customisation options.

On the other hand, could exposing all the props be problematic if, e.g, the consumer decides to render NavigatorButton as any other element/component ? All those ButtonPropsAsButton props would not really make sense — and any non-optional prop could also become annoying, since TS would require it even if it didn't made sense with the as prop.

Maybe an option could be to re-use all props of ButtonPropsAsButton, but intentionally marking them as optional ?

Any thoughts?

[github-actions]

Flaky tests detected in ceb13a1.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4114034401
📝 Reported issues:

• [Flaky Test] List #47632 in specs/editor/blocks/query.test.js
• [Flaky Test] should write over selection #39938 in specs/editor/various/multi-block-selection.test.js

[kienstra]

Hi @ciampo,
Good idea to refer to the <Button> props for when it's a <button>.

[kienstra]

Good idea to simplify this!

[ntsekouras]

Cherry-picked this PR to the wp/6.2 branch.