Navigation: Fixes undo and redo for nesting operations in the navigation block's inspector #47633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
changed the title
draganescu
added
[Type] Bug
|
Size Change: +5 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 41ca909. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4086356238
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
draganescu
force-pushed
the
fix/undo-navigation-nesting
branch
from
83fc750 to
41ca909
Compare
DaisyOlsen
changed the title
scruffian
added
the
Backport to Gutenberg RC
ntsekouras
added
Backport to WP 6.7 Beta/RC
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 9fa1e90 |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 21, 2023
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
draganescu
added
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #46476 - when creating nesting or removing nesting, the operation cannot be undone
Why?
It's a bug: undo and redo needs to work across all editor aspects.
How?
Mark navigation inner blocks conversions for nesting as not persistent.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
undo-redo-fix.mp4