-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Position Block Support: Add PHP tests #47626
Conversation
Flaky tests detected in 0bb453e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4061201904
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the added tests @andrewserong 👍
I've run the tests locally and they pass as per the Github action. The code looks good to me except for a small copy/paste typo.
Happy to approve this pending the suggested tweak. Nice work!
Co-authored-by: Aaron Robertshaw <[email protected]>
Excellent, thanks for the speedy review and spotting the typo! Committed and enabled auto-merge 👍 |
* Position Support: Add PHP tests * Remove unneeded queries line * Update code comment Co-authored-by: Aaron Robertshaw <[email protected]> --------- Co-authored-by: Aaron Robertshaw <[email protected]>
I just cherry-picked this PR to the release/15.1 branch to get it included in the next release: 752ec31 |
What?
Part of #47043 and following on from #46142
Add PHP tests for the position block support.
Why?
How?
Testing Instructions
Check that the PHP tests Github action passes, or run manually via: