Navigation: Remove the Gutenberg plugin check #47579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -236 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8626cfe. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4046663435
|
draganescu
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Excellent cleanup with this. This PR removes all the conditions that kept the pre experiment behavior around, making sure this UX for the navigation block lands in core in the next release.
Given the component that enables it is now exported as an experiment and in my testing this PR does not break anything, lets 🚢 it!
juanmaguitar
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Now that this component is marked as an experiment (#47465), we can remove the IS_GUTENBERG_PLUGIN check from this code.
Why?
This will allow the experimental component to be part of the 6.2 release without risking other developers using it.
How?
Just removes the IS_GUTENBERG_PLUGIN conditionals.
Testing Instructions
Testing Instructions for Keyboard
As above