Block Library: Decode entities in page list item title #47571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
draganescu,
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
tyxla
added
[Type] Enhancement
|
Size Change: +15 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While working on #47570, I noticed that we're not decoding the entities in page titles. This PR addresses that.
Why?
Some HTML entities might appear odd in the page list block:
The first block is a customized Navigation block, and the second one is a Navigation that renders as a Page List block.
You can see how in the Page List block, there's a title containing
that is properly rendered as a space in the first block.How?
We're escaping entities in the page list item, just like in #47570.
Testing Instructions
Test <> Test.Page Listblock.Test <> Test, without the .