Lodash: Refactor Categories List block away from _.unescape()
#47561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
ntsekouras
approved these changes
Jan 30, 2023
|
Size Change: -4 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 18f9419. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4045288697
|
This was referenced Jan 30, 2023
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.unescape()from theCategories Listblock. There is just a single use in that block and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're replacing
_.unescape()withdecodeEntities()from@wordpress/html-entities.This change also introduces a fix.
unescape()does not escape and will render it as-is. So in the current version of the code, if you create a category with in it, that will be rendered as-is in the Categories List block. I believe that's not desired behavior, and that's confirmed by the fact that when editing a category in the admin, the in category titles is converted to a simple space.Testing Instructions
/wp-admin/edit-tags.php?taxonomy=category<script>alert(1)</script>.test > < test.test > < testwill be created. is replaced with a regular space.(Untitled).test > < test.