Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH action warning by upgrading actions/checkout #47494

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Jan 27, 2023

When inspecting GitHub action results, I accidentally noticed this warning for the "Validate Gradle Wrapper" check:

Screenshot 2023-01-27 at 13 25 29

Solving it by updating the actions/checkout action declaration to v3.1.0. If you search all other references to actions/checkout in our other actions, you'll they use the same version with the same hash. The "Validate Gradle Wrapper" action was the only exception. Because it was added recently, after the last mass-upgrade of the action versions.

@jsnajdr jsnajdr added the [Type] Build Tooling Issues or PRs related to build tooling label Jan 27, 2023
@jsnajdr jsnajdr requested review from oguzkocer and tyxla January 27, 2023 12:31
@jsnajdr jsnajdr self-assigned this Jan 27, 2023
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I restarted the failing RN tests since I believe the failure shouldn't be related.

@github-actions
Copy link

Flaky tests detected in 4714826.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4024493562
📝 Reported issues:

@jsnajdr jsnajdr merged commit b61dca9 into trunk Jan 27, 2023
@jsnajdr jsnajdr deleted the update/gh-checkout-action branch January 27, 2023 13:30
@github-actions github-actions bot added this to the Gutenberg 15.1 milestone Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants