Fix padding and margin visualizer positioning #47483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: +8 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
It feels like "block-toolbar" is not the right name for that slot anymore :). Could be "block-ui" or something. Anyway, that's a problem for another day. |
youknowriad
approved these changes
Jan 27, 2023
|
Flaky tests detected in 1f4bbf8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4022452209
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #47471, an issue where the margin and padding visualizers became misaligned whenever block spacing is applied to the layout.
Why?
The visualizer popovers were rendering within the editor canvas
iframe, inline within the block list. This made them susceptible to CSS that's meant to be applied to blocks.In this case, the block spacing's
margin-block-startstyle was being applied to the popover, making it appear misaligned with the block itself.How?
This PR makes the visualizer popovers use the
block-toolbarslot, so that they render outside of the editor canvas iframe.I did try this originally when trying to fix #47139, and noticed some other problems with the visualizers, but I'm not seeing any issues in this PR 🤔
Testing Instructions
Expected: the visualizer should appear correctly overlayed on top of the block.
In trunk: the visualizer is misaligned
Screenshots or screencast
Before
After