URLInput test: use valid url value to pass through validation #47444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -24.6 kB (-2%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Jan 26, 2023
Comment on lines
137
to
140
| function TestInputButton() { | ||
| const [ url, onChange ] = useState( '' ); | ||
| return <URLInputButton url={ url } onChange={ onChange } />; | ||
| } |
There was a problem hiding this comment.
I think it's worth adding a comment explaining why we're adding the wrapper component. It might be unclear to someone looking at the test without context.
juanmaguitar
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one
URLInputunit test that starts failing after Jest upgrade (WIP in #47388), namely after upgrade of the bundled JSDOM (from 16.0 to 20.0).The "should close the form when user submits it" test is rendering a controlled
<URLInputButton>component without aurlvalue prop, and then types something into that component's<input>field. But because there's no value, theinput's value doesn't really change. It remains empty.The
URLInputButtonrenders a form that's like:and our test clicks the "submit" button. However, JSDOM implemented form validation in v18, and because the
requiredinput is empty, it won't submit the form.This PR fixes the test by rendering a helper component that maintains the input state.