Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crowdsignal Embed Variation for a new oEmbed endpoint #47382

Merged

Conversation

audrasjb
Copy link
Contributor

What?

This PR is a follow-up to this WordPress Core Trac ticket: https://core.trac.wordpress.org/ticket/57543

Why?

This adds a new variation for another CrownSignal oEmbed endpoint, which is going to be added on WordPress Core side.

How?

Add a new oEmbed endpoint for Crowdsignal.
See this patch, proposed on the related Core Trac ticket: https://core.trac.wordpress.org/attachment/ticket/57543/crowdsignalnet.diff

@audrasjb audrasjb requested a review from ajitbohra as a code owner January 24, 2023 14:57
@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Embed Affects the Embed Block labels Jan 31, 2023
@Mamaduka Mamaduka self-requested a review January 31, 2023 13:53
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Thanks, @audrasjb!

@Mamaduka Mamaduka merged commit 1426400 into WordPress:trunk Jan 31, 2023
@github-actions github-actions bot added this to the Gutenberg 15.1 milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants