Tag cloud: Disable clicking on the tag links in the editor #47338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
Needs Accessibility Feedback
|
Size Change: +9 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b56bb0f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3983124910
|
|
This bug happens every now and then as people implement new blocks, and I wonder if Or at the very least, for compatibility, raise a warning, something like:
|
mburridge
added
the
Backport to Gutenberg RC
mburridge
pushed a commit
that referenced
this pull request
Jan 23, 2023
mburridge
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Wraps the tag cloud block in
<Disabled>to prevent clicking the tag links while in the editors.Closes #47295
Why?
Clicking the links would try to load the link target inside the editors.
It was easy to click the links by mistake when trying to select the block.
Testing Instructions
After placing the block, clicking anywhere in the block, including direct clicks on the tag links, should select the block, not the link.
Testing Instructions for Screen reader users
Before this PR, the screen reader would announce the individual links inside the tag cloud.
With this change, the screen reader will only announce the block name when selected, and will not read the inner content.
Not receiving information about the tag links that are present is a regression, is there a better way to disable the clicking?
The block is server side rendered.