E2E (cover.test.js): Wait for the height input element #47294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +586 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
jsnajdr
approved these changes
Jan 19, 2023
| )[ 0 ]; | ||
| const heightInput = await page.waitForSelector( | ||
| 'input[id*="block-cover-height-input"]' | ||
| ); |
There was a problem hiding this comment.
Is there an idiomatic way in Puppeter/Playwright to find an input labelled as "Minimum height of cover"? React Testing Library can do it with the .getByLabelText query. If there is a <label for="x"> with that text and the for attribute points to an <input id="x">, it will return the input.
There was a problem hiding this comment.
Is there an idiomatic way in Puppeter/Playwright to find an input labelled as "Minimum height of cover"?
Not in Puppeteer, but fortunately, there is one in Playwright:
await page.getByLabel("Minimum height of cover");We should definitely use it when this spec is migrated.
There's also an asynchronous |
tyxla
approved these changes
Jan 20, 2023
|
Flaky tests detected in 9b18ea6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3966668605
|
juanmaguitar
added
the
[Type] Build Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix failing spec when the concurrent mode is enabled (#46467 (comment)):
How?
Update the input element selector so we can wait until it's available.
✅ Tested against changes in #46467.