E2E (multi-entity-saving.test.js): Wait for the font size picker controls to appear #47242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
jsnajdr
approved these changes
Jan 18, 2023
tyxla
approved these changes
Jan 18, 2023
|
@Mamaduka, looks like all the Puppeteer jobs are failing. I've tried rerunning it, but it's still failing. Any idea what's up? 🤔 |
|
@WunderBart, I see the following errors in the logs:
Can you reproduce the issue locally? You might want to run |
|
I just confirmed. The following URL, which is used to load admin styles, triggers a 500 error on the latest trunk. |
aristath
force-pushed
the
update/e2e-wait-for-ui/multi-entity-saving
branch
from
35941b0 to
ff6844a
Compare
|
I rebased the PR, let's see if tests pass now 👍 |
|
Flaky tests detected in ff6844a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3958135170
|
juanmaguitar
added
the
[Type] Build Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix failing spec when the concurrent mode is enabled (#46467 (comment)):
multi-entity-saving.test.js: Site Editor > Save flow should allow re-saving after changing the same block attributeHow?
Wait for the font size picker controls to appear before interacting with them.
✅ Tested against changes in #46467.