Browse mode: Add an H2 inside the sidebar navigation screen title #47241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
the
[Feature] Site Editor
|
Size Change: +842 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 287e584. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3967908081
|
youknowriad
reviewed
Jan 19, 2023
packages/edit-site/src/components/sidebar-navigation-screen/index.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Jan 19, 2023
packages/edit-site/src/components/sidebar-navigation-screen/index.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Jan 19, 2023
packages/edit-site/src/components/sidebar-navigation-screen/index.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Jan 19, 2023
packages/edit-site/src/components/sidebar-navigation-screen/style.scss
Outdated
Show resolved
Hide resolved
youknowriad
approved these changes
Jan 20, 2023
| ) } | ||
| </HStack> | ||
| title={ config[ postType ].labels.title } | ||
| action={ |
There was a problem hiding this comment.
For consistency, I'd probably rename this prop to actions as we've been using a similar prop in other components.
annezazu
added
the
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Places the words design, templates and template parts inside
h2elements in the navigation sidebar in the Site Editor.Closes #47217
Why?
Text that visually looks like headings should use HTML heading elements.
By using heading elements for the visual heading texts instead of divs, users can use the headings to navigate to the content; the list of buttons that represents the templates and template parts.
How?
Updates the sidebar navigation screen title div:
Adds a new condition for displaying either the heading text or the inner elements that include the
the back button, the template/template parts heading and the add new button.
Testing Instructions
H2.H2.Testing Instructions for Screen reader
Note that this document does not have an H1. This will be implemented in a separate PR.
Screenshots or screencast