Lodash: Deprecate _.map()
#47216
Merged
Lodash: Deprecate _.map()
#47216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 31ad2dc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3939113968
|
tyxla
force-pushed
the
remove/lodash-map
branch
from
31ad2dc to
9dc53a0
Compare
tyxla
removed
the
[Status] Blocked
tyxla
requested review from
Mamaduka,
ntsekouras,
jsnajdr,
flootr,
sgomes,
brookewp and
chad1008
sgomes
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR deprecates Lodash's
_.map()in our ESLint config, since it's no longer in use.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're adding a rule to forbid the usage of
_.map()through ESLint.Testing Instructions
No testing is necessary.