Lodash: Refactor components away from _.map()
#47192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
enejb,
Mamaduka,
sgomes,
mirka,
aristath,
jsnajdr,
swissspidy,
ciampo,
geriux,
flootr,
chad1008,
fluiddot,
ntsekouras,
fabiankaegy and
brookewp
tyxla
commented
Jan 16, 2023
| @@ -70,7 +69,7 @@ export function getAutoCompleterUI( autocompleter ) { | |||
| role="listbox" | |||
| className="components-autocomplete__results" | |||
| > | |||
| { map( items, ( option, index ) => ( | |||
| { items.map( ( option, index ) => ( | |||
There was a problem hiding this comment.
items is already being used as an array earlier in this component.
| @@ -64,13 +63,21 @@ function ColorPalette( { | |||
| const opacity = useRef( new Animated.Value( 1 ) ).current; | |||
|
|
|||
| const defaultColors = [ | |||
| ...new Set( map( defaultSettings.colors, 'color' ) ), | |||
| ...new Set( | |||
| ( defaultSettings.colors ?? [] ).map( ( { color } ) => color ) | |||
There was a problem hiding this comment.
Theoretically, colors could be undeclared, so we're defaulting to an empty array.
| ]; | ||
| const mergedColors = [ | ||
| ...new Set( map( defaultSettings.allColors, 'color' ) ), | ||
| ...new Set( | ||
| ( defaultSettings.allColors ?? [] ).map( ( { color } ) => color ) |
There was a problem hiding this comment.
Theoretically, allColors could be undeclared, so we're defaulting to an empty array.
| ]; | ||
| const defaultGradientColors = [ | ||
| ...new Set( map( defaultSettings.gradients, 'gradient' ) ), | ||
| ...new Set( | ||
| ( defaultSettings.gradients ?? [] ).map( |
There was a problem hiding this comment.
Theoretically, gradients could be undeclared, so we're defaulting to an empty array.
| target={ target } | ||
| /> | ||
| ) ); | ||
| const element = Object.entries( shortcuts ?? {} ).map( |
There was a problem hiding this comment.
This is externally exposed API, so it could be nullish, therefore we're falling back to an empty object just in case.
tyxla
force-pushed
the
refactor/lodash-map-components
branch
from
e7c1d7d to
75debe4
Compare
|
Size Change: +10 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 75debe4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3932135003
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.map()from the components package. There are just a few usages and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
Array.prototype.map()instead, with nullish coalescing where necessary.Testing Instructions