Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performances: Avoid UI shifting when selecting blocks #47177

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Performances: Avoid UI shifting when selecting blocks #47177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3a9e63
fix: avoid ui shifting when selecting blocks
Mar 9, 2023
c53f893
Update style.scss
corentin-gautier Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/edit-post/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,15 @@ body.block-editor-page {

@include wordpress-admin-schemes();

.interface-interface-skeleton__header {
@supports (scrollbar-gutter: stable) {
// The scrollbar-gutter property ensures space is reserved for the scrollbar to appear,
// when scrollbars are set to be always visible. This ensure icons stay visually aligned.
scrollbar-gutter: stable;
overflow: hidden;
}
}

// The edit-site package adds or removes the sidebar when it's opened or closed.
// The edit-post package, however, always has the sidebar in the canvas.
// These edit-post specific rules ensures there isn't a border on the right of
Expand All @@ -109,6 +118,7 @@ body.block-editor-page {
.is-sidebar-opened & {
@include break-medium() {
border-left: $border-width solid $gray-200;
overflow: hidden scroll;
}
}
}