In-between inserter: Fix console error when moving mouse in Firefox #47168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Feature] Inserter
|
Size Change: +24 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
I've noticed that the inserter also appears in browse mode in firefox. I guess it's unrelated with this PR though. |
|
@youknowriad
I was able to reproduce this problem with trunk and have submitted #47190. I would like to merge this PR as I believe it isn't the cause of the problem. |
juanmaguitar
added
the
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #47165
What?
This PR fixes console errors output when moving the mouse in FireFox.
Why?
I was unable to find the root cause, but as this video shows, I discovered that the mouse move event also detects text nodes. The text node does not have a
classList, resulting in a console error.How?
Checking if the node type is a text node.
Testing Instructions