Block Inserter: Correctly apply style to the default inserter #47166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +13 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
t-hamano
commented
Jan 15, 2023
| @@ -59,7 +59,6 @@ | |||
|
|
|||
| // Sibling inserter / "inbetweenserter". | |||
| .block-editor-block-list__empty-block-inserter, | |||
| .block-editor-default-block-appender, | |||
There was a problem hiding this comment.
I think the default inserter will not be used outside of the iframe editor, so I removed it.
t-hamano
added
[Type] Bug
|
Flaky tests detected in 09812c4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3921844822
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
useBlockPreviewstyles in iframe #47110What?
This PR fixes two problems with the default block inserter style not being applied in the block theme and site editor.
1.Nested block inserter is not square:
Why?
In #44298, the styles loaded into the iframe editor instance were separated. The default inserter (
.block-editor-default-block-appender) is loaded in the iframe, so it must be defined incontent.css, notstyle.css.The Classic theme does not have this problem because the iframe editor is not used and both stylesheets are loaded:
How?
Moved styles related to default inserters from
style.csstocontent.css.Testing Instructions
I think we need to check all the inserters below, both block and classic themes, just to be sure.