Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HStack docs to show code sample #47162

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fix HStack docs to show code sample #47162

merged 1 commit into from
Jan 19, 2023

Conversation

brookewp
Copy link
Contributor

What?

The docs for HStack are inconsistent between VStack and ZStack as the sample code isn't showing.

Why?

To make it consistent with other docs.

How?

By removing @example as discussed with @mirka

Testing Instructions

  1. npm run storybook:dev
  2. Go to HStack docs
  3. Ensure sample code shows

Before:

Screenshot 2023-01-11 at 3 34 04 PM

After:

Screenshot 2023-01-11 at 3 33 40 PM

@brookewp brookewp added [Type] Enhancement A suggestion for improvement. Storybook Storybook and its stories for components labels Jan 14, 2023
@brookewp brookewp requested a review from ajitbohra as a code owner January 14, 2023 09:01
@brookewp brookewp self-assigned this Jan 14, 2023
@brookewp brookewp marked this pull request as draft January 14, 2023 18:52
@brookewp brookewp marked this pull request as ready for review January 17, 2023 00:43
@brookewp brookewp requested review from mirka, chad1008 and ciampo January 17, 2023 00:43
@brookewp
Copy link
Contributor Author

Would this kind of change need an internal comment in the changelog?

mirka
mirka approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this kind of change need an internal comment in the changelog?

I think it's fine without 👍

@brookewp brookewp merged commit c00e0f0 into trunk Jan 19, 2023
@brookewp brookewp deleted the fix/hstack-stories-docs branch January 19, 2023 16:22
@github-actions github-actions bot added this to the Gutenberg 15.1 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirka mirka mirka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@chad1008 chad1008 Awaiting requested review from chad1008

@ciampo ciampo Awaiting requested review from ciampo

Assignees

@brookewp brookewp

Labels
Storybook Storybook and its stories for components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 15.1
Development

Successfully merging this pull request may close these issues.
2 participants
@brookewp @mirka