Template Parts: Avoid duplicate names on conversion from group of blocks #47082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le is unique on conversion.
|
Size Change: +7 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 376faba. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3895396872
|
apeatling
changed the title
andrewserong
approved these changes
Jan 12, 2023
|
I think I just found a subtle issue when we go to create a duplicate template part when the template part we're matching against hasn't had any user changes — apologies, I didn't catch this in the initial testing, since I'd been using a theme I've made lots of changes to! Looks like it's a pretty small change to tidy it up, so I've opened up a follow-up PR in #47128 |
noisysocks
reviewed
Jan 13, 2023
| */ | ||
| export const getCleanTemplatePartSlug = ( title ) => { | ||
| return kebabCase( title ).replace( /[^\w-]+/g, '' ) || 'wp-custom-part'; | ||
| }; |
There was a problem hiding this comment.
These three would be great functions to unit test.
There was a problem hiding this comment.
Sounds good, I'll look at figuring this out 👍
There was a problem hiding this comment.
PR for tests #47224
juanmaguitar
added
the
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #46996
What?
When selecting a group of blocks and the using "Create template part" from the menu, make sure that the name used for the template part in the modal is not a duplicate. This matches with the functionality in #46996.
Why?
Original issue is #42473
How?
Since creation and conversion of template parts is two different components, I've taken the liberty of moving shared functionality to the
utilsdirectory. Open to thoughts on whether this is the right place?Testing Instructions
Screenshots or screencast