Add custom label to nav block list view appender #47033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
Needs Accessibility Feedback
getdave
changed the title
|
Size Change: +28 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
getdave
added
the
[Feature] Inserter
scruffian
reviewed
Jan 10, 2023
packages/block-editor/src/components/off-canvas-editor/appender.js
Outdated
Show resolved
Hide resolved
|
Flaky tests detected in b01d5f8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3902349810
|
talldan
reviewed
Jan 11, 2023
talldan
reviewed
Jan 11, 2023
getdave
force-pushed
the
try/custom-label-to-nav-block-list-view-appender
branch
from
accf7b3 to
d0c2283
Compare
|
Is this expected to work with VoiceOver? In my testing it only reads the label, not the aria-describedby:
Just to confirm I can see it in the markup: |
|
Code looks good, but it doesn't seem to work in my testing... |
|
It should work. Let me re-test in case I broke something |
|
There seems to be a bug in Firefox which means that when aria-label is defined aria-describedby doesn't work. I think we should merge this. |
scruffian
approved these changes
Jan 12, 2023
scruffian
deleted the
try/custom-label-to-nav-block-list-view-appender
branch
|
From what I understand, Voiceover doesn't work reliably with browsers other than Safari, so things like that happen from time to time. |
talldan
reviewed
Jan 13, 2023
| @@ -32,14 +33,20 @@ export const Appender = forwardRef( | |||
| }; | |||
| }, [] ); | |||
|
|
|||
| const blockTitle = useBlockDisplayTitle( { | |||
| clientId, | |||
There was a problem hiding this comment.
There are a couple of things to be careful about with this if/when the feature is ported to the main List View.
This clientId is for the selected block, whereas it should be for the parent block. For the main List View it'd always append at root level, so it'd have to say 'Append to post' or something.
priethor
added
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Renames the accessible name for the appender in the Navigation block list view to beAdd block to Navigation menu. As requested in #47011.Update to add the name of the block to the
aria-describedByattribute so that it reads in the form:The
Add blockbutton remains "as is" but the additional context is provided by the area description.Closes #47011
Why?
Currently just
Add block(the default) has been reported as overly generic and lacking context for users of assistive tech.This PR adds additional context to the button.
How?
Augment the existing
aria-describedbywith information about the block to which the new block will be appended,.Testing Instructions
Check when you focus the appender with a screen reader you hear
Append to Navigation block at position 1, Level 1shortly after focusing the block appender in the Nav list view.Testing Instructions for Keyboard
Ensure appender continues to be keyboard focusable.
Screenshots or screencast