Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help text on the HTML element for the Comments and Query Loop blocks #46989

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Jan 9, 2023

What?

Adding dynamic help text on the HTML element for the Comments and Query Loop blocks

Fixes #46967

Why?

So that it can be in line with what there is on the Group block, adding helpful information about this particular option.

How?

Replicating the array of messages that we already have for the Group block, and adding that to the mentioned blocks.

Testing Instructions

  1. Create a post or page.
  2. Add the Comments and Query Loop blocks.
  3. Confirm that when you switch the HTML element (on the advanced options) you get the proper help text for each tag.

Testing Instructions for Keyboard

Screenshots or screencast

Screen.Recording.2023-01-09.at.17.18.52.mov

Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@carolinan
Copy link
Contributor

The PR works well, thank you.
Is there a reason why the template part was not updated? Maybe it was only forgotten?

@juanfra
Copy link
Member Author

juanfra commented Jan 10, 2023

Thanks for the heads up @carolinan - I totally missed that one. I've just committed the changes for that block.

Screen.Recording.2023-01-10.at.12.37.16.mov

@carolinan carolinan added the [Type] Enhancement A suggestion for improvement. label Jan 11, 2023
@carolinan carolinan merged commit 85eb13a into WordPress:trunk Jan 11, 2023
@github-actions github-actions bot added this to the Gutenberg 15.0 milestone Jan 11, 2023
@juanfra juanfra deleted the fix/46967 branch January 11, 2023 09:50
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced panel HTML element selection is missing help text
4 participants