MediaUtils: move window access to function bodies
#46970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flootr
added
[Package] Blob
|
Size Change: +44 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9fc28ef. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3872999115
|
jsnajdr
approved these changes
Jan 16, 2023
juanmaguitar
added
the
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Move access to the global
window.wpobject to respective function bodies for the@wordpress/media-utilsand@wordpress/blobpackages.This issue was brought up in the WordPress Slack core-js channel (https://wordpress.slack.com/archives/C5UNMSU4R/p1668693333126039).
Why?
Currently, it's not possible to use those packages (or packages that depend on them) in a Node.js environment because the global
windowis not available there.How?
By moving access to
window.wpto those functions a Node.js process won't fail during static initialization.Testing Instructions
To test whether the import of the
@wordpress/media-utilspackage fails create a local project and add the@wordpress/media-utilspackage as a dependency. It's sufficient to just imort that package in a file. I used these steps:Create a file
index.mjswhich contains the corresponding importThen execute
node index.mjson the command line.To test whether this patch fixes the process failure described above use that exact project and link the dependency by using
npm link.packages/media-utilsnpm link(make sure to runnpm build:packagesbefore)npm link @wordpress/media-utils(it may be necessary to do that for@wordpress/blob, too).node index.mjsagain