Remove the border property from the body element on previews. #46946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
reviewed
Jan 9, 2023
| @@ -91,6 +91,9 @@ function ScaledBlockPreview( { | |||
| documentElement.style.width = '100%'; | |||
| bodyElement.style.padding = __experimentalPadding + 'px'; | |||
|
|
|||
| // Necessary for proper previews of styles with border styles assigned to the body. | |||
| bodyElement.style.border = 'none'; | |||
There was a problem hiding this comment.
It's interesting that some styling is set using JavaScript here and some is set using CSS on line 52 above. Did you consider putting border: none into the CSS above? What's the better approach?
There was a problem hiding this comment.
Thanks for the CR, @noisysocks :)
I initially chose that place, so that I can add some inline docs explaining the reason behind removing the border. Maybe line 52 is cleaner, I've just moved it there.
There was a problem hiding this comment.
Much of a muchness I suppose, thanks for considering 😀
noisysocks
added
[Type] Bug
carolinan
approved these changes
Jan 10, 2023
noisysocks
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixing #46874.
Why?
Because the style book and the different previews don’t show examples properly on variants where there's a body border defined.
How?
Removing the body border from the preview so that the styles preview doesn't look borked.
Testing Instructions
Screenshots or screencast
gutenberg-46874.mov