-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add box shadow support to blocks (using code editor for now). #46896
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
acacb73
Add box shadow support via templates
madhusudhand b77ff99
Fix comment and linting issues
glendaviesnz e5e98e1
more linting issues
glendaviesnz 474d634
Switch to block_has_support method to check for support
glendaviesnz 70a2e72
Update second call to _wp_array_get
glendaviesnz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
<?php | ||
/** | ||
* Shadow block support flag. | ||
* | ||
* @package gutenberg | ||
*/ | ||
|
||
/** | ||
* Registers the style and shadow block attributes for block types that support it. | ||
* | ||
* @param WP_Block_Type $block_type Block Type. | ||
*/ | ||
function gutenberg_register_shadow_support( $block_type ) { | ||
$has_shadow_support = block_has_support( $block_type, array( 'shadow' ), false ); | ||
|
||
if ( ! $has_shadow_support ) { | ||
return; | ||
} | ||
|
||
if ( ! $block_type->attributes ) { | ||
$block_type->attributes = array(); | ||
} | ||
|
||
if ( $has_shadow_support && ! array_key_exists( 'style', $block_type->attributes ) ) { | ||
$block_type->attributes['style'] = array( | ||
'type' => 'object', | ||
); | ||
} | ||
|
||
if ( $has_shadow_support && ! array_key_exists( 'shadow', $block_type->attributes ) ) { | ||
$block_type->attributes['shadow'] = array( | ||
'type' => 'string', | ||
); | ||
} | ||
} | ||
|
||
/** | ||
* Add CSS classes and inline styles for shadow features to the incoming attributes array. | ||
* This will be applied to the block markup in | ||
* the front-end. | ||
* | ||
* @param WP_Block_Type $block_type Block type. | ||
* @param array $block_attributes Block attributes. | ||
* | ||
* @return array Shadow CSS classes and inline styles. | ||
*/ | ||
function gutenberg_apply_shadow_support( $block_type, $block_attributes ) { | ||
if ( ! property_exists( $block_type, 'supports' ) ) { | ||
return array(); | ||
} | ||
|
||
$has_shadow_support = _wp_array_get( $block_type->supports, array( 'shadow' ), false ); | ||
if ( ! $has_shadow_support ) { | ||
return array(); | ||
} | ||
|
||
$shadow_block_styles = array(); | ||
|
||
$preset_shadow = array_key_exists( 'shadow', $block_attributes ) ? "var:preset|shadow|{$block_attributes['shadow']}" : null; | ||
$custom_shadow = isset( $block_attributes['style']['shadow'] ) ? $block_attributes['style']['shadow'] : null; | ||
$shadow_block_styles['shadow'] = $preset_shadow ? $preset_shadow : $custom_shadow; | ||
|
||
$attributes = array(); | ||
$styles = gutenberg_style_engine_get_styles( $shadow_block_styles ); | ||
|
||
if ( ! empty( $styles['css'] ) ) { | ||
$attributes['style'] = $styles['css']; | ||
} | ||
|
||
return $attributes; | ||
} | ||
|
||
// Register the block support. | ||
WP_Block_Supports::get_instance()->register( | ||
'shadow', | ||
array( | ||
'register_attribute' => 'gutenberg_register_shadow_support', | ||
'apply' => 'gutenberg_apply_shadow_support', | ||
) | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use
block_has_support
here too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, missed that, done.