-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: fix unnatural rounded corners in view mode #46792
Conversation
Size Change: -35 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Thank you for the PR! Actually we don't want to change this radius, because the viewport is supposed to be content-only, with no extra editor UI. Which is also to say that the fact the notices are showing is the bug we need to fix, i.e. #46274. To my knowledge, those notices aren't actionable in that context anyway, so they shouldn't show up. |
Thank you, you are right. |
Fixes #46783
What?
This PR fixes unnatural rounded corners when the notice data is present in the view mode of the site editor.
Why?
The rounded corners are caused by the fact that
border-radius
is added to the iframe canvas itself.I don't know why this style is applied, but removing this doesn't seem to affect the rest of the canvas.
How?
Style removed.
Testing Instructions
To display the notification bar, execute the following code in the console:
Alternatively, you can clear template customization to display the notification "Template reverted."
Screenshots or screencast
I have checked various layouts in this PR and the clearing of rounded corners doesn't appear to affect other areas.
Screenshots