Site Editor: fix unnatural rounded corners in view mode #46792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
the
[Feature] Site Editor
|
Size Change: -35 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Thank you for the PR! Actually we don't want to change this radius, because the viewport is supposed to be content-only, with no extra editor UI. Which is also to say that the fact the notices are showing is the bug we need to fix, i.e. #46274. To my knowledge, those notices aren't actionable in that context anyway, so they shouldn't show up. |
|
Thank you, you are right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46783
What?
This PR fixes unnatural rounded corners when the notice data is present in the view mode of the site editor.
Why?
The rounded corners are caused by the fact that
border-radiusis added to the iframe canvas itself.I don't know why this style is applied, but removing this doesn't seem to affect the rest of the canvas.
How?
Style removed.
Testing Instructions
To display the notification bar, execute the following code in the console:
Alternatively, you can clear template customization to display the notification "Template reverted."
Screenshots or screencast
I have checked various layouts in this PR and the clearing of rounded corners doesn't appear to affect other areas.
Screenshots