URLInput: Deprecate bottom margin #46692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +180 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
brookewp
force-pushed
the
update/urlinput-margin
branch
from
74c74a0 to
1ec0079
Compare
brookewp
commented
Dec 21, 2022
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| - `URLInput`: the `renderSuggestions` callback prop now receives `currentInputValue` as a new parameter ([45806](https://github.com/WordPress/gutenberg/pull/45806)). | |||
There was a problem hiding this comment.
I see that URLInput is included in the changelog already. Should I have added my PR below, or is it fine the way I did it?
20 tasks
mirka
reviewed
Dec 22, 2022
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| - `URLInput`: the `renderSuggestions` callback prop now receives `currentInputValue` as a new parameter ([45806](https://github.com/WordPress/gutenberg/pull/45806)). | |||
Comment on lines
485
to
486
| since: '6.1', | ||
| version: '6.4', |
There was a problem hiding this comment.
Suggested change
| since: '6.1', | |
| version: '6.4', | |
| since: '6.2', | |
| version: '6.5', |
I guess this will now be 6.2 because 6.1 was already released.
mirka
added
the
Needs Dev Note
brookewp
force-pushed
the
update/urlinput-margin
branch
from
0e165a0 to
d315f19
Compare
mirka
changed the title
49 tasks
brookewp
added
the
has dev note
ciampo
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #39358
Part of #38730
What?
Adds a
__nextHasNoMarginBottomprop to remove the bottom margin.Why?
For easier reuse and consistency in spacing.
How?
This PR just adds the flags. The in-repo migration and official deprecation tasks will continue to be tracked at #39358.
Testing Instructions
Dev Note
This note could be merged with the note in #38730
Components with deprecated margin styles
A number of UI components currently ship with styles that give them top and/or bottom margins. This can make it hard to reuse them in arbitrary layouts, where you want different amounts of gap or margin between components.
To better suit modern layout needs, we will gradually deprecate these outer margins. A deprecation will begin with an opt-in period where you can choose to apply the new margin-free styles on a given component instance. Eventually in a future version, the margins will be completely removed.
In WordPress 6.2, the bottom margin on the
URLInputcomponent has been deprecated.To start opting into the new margin-free styles, set the
__nextHasNoMarginBottomprop totrue: