Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Styles: Add a css style to theme.json to allow setting of custom css strings #46255

Merged
merged 5 commits into from
Dec 2, 2022
Merged

Global Styles: Add a css style to theme.json to allow setting of custom css strings #46255

merged 5 commits into from
Dec 2, 2022

Conversation

glendaviesnz
Copy link
Contributor

What?

Adds a css property to theme.json styles to allow setting of custom CSS strings as part of global styles

Why?

Part of #30142

How?

Updates the theme.json schema

Testing Instructions

  • Check that the schema settings look correct

@glendaviesnz glendaviesnz added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Dec 1, 2022
@glendaviesnz glendaviesnz self-assigned this Dec 1, 2022
@glendaviesnz glendaviesnz requested a review from ajlende as a code owner December 1, 2022 20:41
ajlende
ajlende reviewed Dec 1, 2022
View reviewed changes
Copy link
Contributor

@ajlende ajlende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think css probably needs to be added to stylesElementsPropertiesComplete and stylesPropertiesAndElementsComplete as well.

@glendaviesnz glendaviesnz mentioned this pull request Dec 1, 2022
Closed
10 tasks
@glendaviesnz
Copy link
Contributor Author

I think css probably needs to be added to stylesElementsPropertiesComplete and stylesPropertiesAndElementsComplete as well.

Thanks, done.

@glendaviesnz glendaviesnz mentioned this pull request Dec 1, 2022
Merged
@glendaviesnz glendaviesnz merged commit 32ba7bd into trunk Dec 2, 2022
@glendaviesnz glendaviesnz deleted the add/css-to-theme-json branch December 2, 2022 02:57
@github-actions github-actions bot added this to the Gutenberg 14.8 milestone Dec 2, 2022
mpkelly pushed a commit to mpkelly/gutenberg that referenced this pull request Dec 7, 2022
@glendaviesnz @mpkelly
Add a css style to theme.json to allow setting of custom css strings (W…
a62bf7a 
…ordPress#46255)
@ryanwelcher ryanwelcher changed the title Add a css style to theme.json to allow setting of custom css strings Global Styles: Add a css style to theme.json to allow setting of custom css strings Dec 14, 2022
@bph bph added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajlende ajlende ajlende approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@glendaviesnz glendaviesnz

Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Dev Note Requires a developer note for a major WordPress release cycle
Projects
None yet
Milestone
Gutenberg 14.8
Development

Successfully merging this pull request may close these issues.
3 participants
@glendaviesnz @ajlende @bph