Strip markup from link label data in inspector #46171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Bug
draganescu
changed the title
|
Size Change: +8 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
MaggieCabrera
approved these changes
Nov 30, 2022
draganescu
deleted the
fix/markup-in-inspector-label-field-for-navlink
branch
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When a link is added to a navigation block it can be formatted. This PR removes the markup for formatting from being displayed in the navigation link inspector.
Why?
The editing of the label in the navigation link block's inspector was recently introduced and it erroneously displayed markup if formatting was added to the label in the canvas.
How?
Using the same system of stripping HTML as the one used to display the link label in the LinkUI component.
Testing Instructions
Screenshots or screencast