Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move post/page title to top toolbar #46135

Closed
wants to merge 8 commits into from
Closed

Move post/page title to top toolbar #46135

wants to merge 8 commits into from

Commits on Dec 6, 2022

  1. Move post/page title to top bar 

    The title's position in the editor can be
inaccurate depending on how themes are styled;
to more accurately represent how a post will
look when published, this commit moves the
title from the editor body to the top toolbar.

This mirrors the treatment for the toolbar in
Full Site Editing. For reference, see edit-site/
header-edit-mode/document-actions.
    @artemiomorales
    artemiomorales committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    9b56f36 View commit details
    Browse the repository at this point in the history

  2. Prevent erroneous display of aria-label 

    When 'Show button text labels' is enabled in the
Gutenberg preferences, it causes the aria-label
to display beside the dropdown button unnecessarily.

This commit adds a style to prevent the aria-label
from appearing.
    @artemiomorales
    artemiomorales committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    cbd4d91 View commit details
    Browse the repository at this point in the history

  3. Add style variant to dropdown button

    @artemiomorales
    artemiomorales committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6f31274 View commit details
    Browse the repository at this point in the history

  4. Remove dropdown and convert title to input field

    @artemiomorales
    artemiomorales committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    7e47c77 View commit details
    Browse the repository at this point in the history

  5. Add tooltip, revise label for a11y, revise styles

    @artemiomorales
    artemiomorales committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    d16216d View commit details
    Browse the repository at this point in the history

  6. Style adjustments

    @jameskoster @artemiomorales
    jameskoster authored and artemiomorales committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6cd9e5c View commit details
    Browse the repository at this point in the history

  7. Fix wrapping bug and widen title input 

    Revised styles so that items in the header don't wrap, allowing
the left and center parts of the toolbar to shrink as needed.
We also now hide the undo, redo, mode switcher, and Inspector buttons
at resolutions below the medium breakpoint.

Also, I made it so more characters are visible in the title,
and added ellipsis when the title overflows.
    @artemiomorales
    artemiomorales committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    8dcc497 View commit details
    Browse the repository at this point in the history

  8. Hide inspector button below medium breakpoint

    @artemiomorales
    artemiomorales committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    42cd7a1 View commit details
    Browse the repository at this point in the history