Fix column block category #46048
Merged
Fix column block category #46048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimotmk
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
|
|
Could someone please take a look at this pull request? I find it a bit odd that the categories in the child block column block ( https://developer.wordpress.org/block-editor/reference-guides/core-blocks/#column |
carolinan
approved these changes
Jan 4, 2023
fabiankaegy
approved these changes
May 22, 2023
|
I think this needs to be rebased with a clean trunk branch for the actions to run correctly |
shimotmk
force-pushed
the
fix/column/category
branch
from
869ba4c to
ac4434e
Compare
fabiankaegy
approved these changes
May 22, 2023
cbravobernal
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The column (core/columns) category was a design, but its child block (core/column) was text, so we fixed it.
Please let me know if there is a reason you intended to do this.
Why?
How?
Testing Instructions
Screenshots or screencast