Sidebar: Expand advanced panel if only item in settings tab #46024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
|
|
Size Change: +42 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
aaronrobertshaw
force-pushed
the
try/expanding-advanced-controls
branch
from
6fd922d
to
8280a39
Compare
I don't think there's an easy way to solve this. Even though it's possible to count the
So there are some real technical limitations. The best ideas I had were:
Both feel a bit hacky. |
|
Given the technical limitations around fill count I'm going to close this PR. If the desire for auto-expanding this panel grows, we can revisit the other proposed options. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Expands the Advanced controls panel by default when it is the only item under the sidebar settings tab.
Why?
Having the advanced controls panel remain collapsed when it is the only item in the tab looks odd. Expanding it in this scenario may also save the user a click.
How?
If there are no fills being rendered within the
defaultinspector controls slot, the advanced controls panel has itsinitialOpenprop set totrue.Known Issues
Conditionally rendered fills within the default inspector controls slot pose a problem. For example;
The above code still adds a fill to the slot. I haven't yet found a reliable means of determining that nothing is actually being rendered by the example above to still allow the auto-expansion of the advanced controls panel.
Alternative Approach
I did try setting a flag within a new SettingsTabContext and having any fills toggle that as they render however I couldn't get that working.
Testing Instructions
Screenshots or screencast
Screen.Recording.2022-11-24.at.4.05.13.pm.mp4