Components: Bump DateTimePicker deprecated prop removal version
#46006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
tyxla
requested review from
mirka,
noisysocks,
jsnajdr,
ciampo,
flootr,
chad1008,
ntsekouras and
brookewp
|
|
ntsekouras
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Thanks for the fix @tyxla! It'd be very unfortunate if we have to keep for ever such code.. If we do though, it seems we need to update the eslint rule for deprecations..
That's true. Or we can even remove the rule altogether, if we're not planning to be removing deprecations... Not a sustainable path forward if you ask me, as we'll need to find a better way to deal with cleaning up those deprecations at some point. |
ciampo
added
the
has dev note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR bumps the version in which the deprecated props of
DateTimePickerwill be removed in 6 more months of Gutenberg releases.This is an alternative to #45999.
Closes #45999.
Why?
The
DateTimePickercalendar help has been deprecated since Version 13.4 and was scheduled to be removed for 14.6.Bumping the removal version of the deprecated props fixes the Static Analysis check which is currently failing in
trunk.How?
Simply bumping the deprecated props removal version.
Testing Instructions
Verify all checks are green.
✍️ Dev Note
The removal of the
__nextRemoveHelpButtonand__nextRemoveResetButtonprops on theDateTimePickercomponent in@wordpress/components, initially scheduled for Gutenberg 14.6, has been postponed to the Gutenberg 15.8 release.