Post Author: Avoid errors when the user avatars are disabled #45989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mamaduka
added
[Type] Bug
Mamaduka
commented
Nov 23, 2022
Comment on lines
+65
to
66
| if ( authorDetails?.avatar_urls ) { | ||
| Object.keys( authorDetails.avatar_urls ).forEach( ( size ) => { |
There was a problem hiding this comment.
This is a regression after #43807.
Mamaduka
commented
Nov 23, 2022
| @@ -172,7 +172,7 @@ function PostAuthorEdit( { | |||
| </BlockControls> | |||
|
|
|||
| <div { ...blockProps }> | |||
| { showAvatar && authorDetails && ( | |||
| { showAvatar && authorDetails?.avatar_urls && ( | |||
There was a problem hiding this comment.
I noticed this after fixing the initial regression.
|
Size Change: +11 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
This was referenced Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #45980.
PR fixes the JS error when the user avatar display is disabled for the site.
Why?
The user avatars can be disabled on the site level. The blocks should respect that.
How?
Update logic to guard for missing
avatar_urlsproperty.Testing Instructions
Screenshots or screencast