Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Engine: add first draft of contributing doc #45930

Merged
merged 4 commits into from
Nov 21, 2022

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Nov 21, 2022

What?

Adding some contributor notes that highlight important aspects of Style Engine development.

This is a first draft.

Style Engine tracking issue:

Why?

To explain the build process and naming conventions.

Testing Instructions

Run npm run test:unit:php -- --group style-engine to check that the @group annotation works.

@ramonjd ramonjd added [Type] Developer Documentation Documentation for developers [Package] Style Engine /packages/style-engine labels Nov 21, 2022
@ramonjd ramonjd self-assigned this Nov 21, 2022
@codesandbox
Copy link

codesandbox bot commented Nov 21, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks for adding this in! 🎉

There was one typo, and I left a few little nit comments, but feel free to ignore them if you don't think they're applicable 🙂

packages/style-engine/CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/style-engine/CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/style-engine/CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/style-engine/CONTRIBUTING.md Show resolved Hide resolved
packages/style-engine/CONTRIBUTING.md Outdated Show resolved Hide resolved
@ramonjd
Copy link
Member Author

ramonjd commented Nov 21, 2022

Thanks for the quick review/proofread @andrewserong

Suggestions committed!

@ramonjd ramonjd merged commit 5c445c2 into trunk Nov 21, 2022
@ramonjd ramonjd deleted the add/style-engine-contributing-doc branch November 21, 2022 07:56
@github-actions github-actions bot added this to the Gutenberg 14.7 milestone Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Style Engine /packages/style-engine [Type] Developer Documentation Documentation for developers
Projects
Status: 🏆 Done
Development

Successfully merging this pull request may close these issues.

2 participants