Deprecated get_file_path_from_theme method.

[spacedmonkey]

What?

Part of #45171

Deprecated get_file_path_from_theme method, using the existing get_file_path on the theme object exists. This method has a filter and better documented.

Why?

How?

Testing Instructions

Screenshots or screencast

[codesandbox]

  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

[felixarntz]

Mostly LGTM, however I have a concern on the way the deprecation is being handled. Not necessarily opposed, but I wanna make sure we have thought this through.

[aristath]

Out of curiosity, Is there a reason we don't simply use the get_theme_file_path function? 🤔

[github-actions]

Flaky tests detected in 3298728.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6149298630
📝 Reported issues:

• [Flaky Test] Top level navigation links inherit the text color from the theme/group but do not apply to the submenu or overlay text #53977 in /test/e2e/specs/editor/blocks/navigation-colors.spec.js

[spacedmonkey]

Out of curiosity, Is there a reason we don't simply use the get_theme_file_path function? 🤔

Because we already have a theme instance already.

[spacedmonkey]

Backport from core now this has been merged - WordPress/wordpress-develop@a13f896

[jorgefilipecosta]

The change looks good and matches what we have in the core now, so I think we should merge this PR soon to avoid accidentally reverting the core during backport.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/class-wp-theme-json-resolver-gutenberg.php

[github-actions]

Warning: Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
• Labels found: [Type] Enhancement, [Feature] Block API, Backport from WordPress Core.

Read more about Type labels in Gutenberg.

[github-actions]

Warning: Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
• Labels found: [Type] Enhancement, [Feature] Block API, Backport from WordPress Core.

Read more about Type labels in Gutenberg.