Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Cover Block tests to Playwright #45784

Merged
merged 17 commits into from
May 15, 2023
Merged

Migrate Cover Block tests to Playwright #45784

merged 17 commits into from
May 15, 2023

Commits on Apr 24, 2023

  1. Add new Playwright E2E tests for the cover block.

    @worldomonation
    worldomonation committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    12053c5 View commit details
    Browse the repository at this point in the history

  2. Add comment

    @worldomonation
    worldomonation committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    4ad16be View commit details
    Browse the repository at this point in the history

  3. Update block list selector

    @worldomonation
    worldomonation committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    ff1b3c3 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. test/e2e/specs/editor/blocks/cover.spec.js 

    - update spec with accessibility-based selectors where possible.
    @worldomonation
    worldomonation committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    1594c2d View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. test/e2e/specs/editor/blocks/cover.spec.js 

    - rebase, rebuild and update the selectors
    @worldomonation
    worldomonation committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    2a496d1 View commit details
    Browse the repository at this point in the history

  2. packages/e2e-tests/specs/editor/blocks/cover.test.js 

    - remove Puppeteer file.
    @worldomonation
    worldomonation committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    e409acf View commit details
    Browse the repository at this point in the history

  3. test/e2e/specs/editor/blocks/cover.spec.js 

    - clarify use of `span` element in the first spec.
    @worldomonation
    worldomonation committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    c154640 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. - add comment explaing use of CSS selector for '.components-resizable… 

    …-box__handle-bottom'.

- move image upload and filename methods previously handled by `getTestImage` into a POM-like function at bottom of file.
    @worldomonation
    worldomonation committed May 10, 2023
    Configuration menu
    Copy the full SHA
    071c31b View commit details
    Browse the repository at this point in the history

  2. - remove testing test.only

    @worldomonation
    worldomonation committed May 10, 2023
    Configuration menu
    Copy the full SHA
    77a1b7b View commit details
    Browse the repository at this point in the history

  3. - define the coverBlock locator after inserting the block, and use th… 

    …at locator as starting point for all other interactions.

- use `getComputedStyle` instad of `node.style.<attribute>`.
- replace implementation detail check on image upload with a `expect.toPass` check.
- remove steps when resizing box.
- replace implementation detail check for coverbox height with truthy check.
    @worldomonation
    worldomonation committed May 10, 2023
    Configuration menu
    Copy the full SHA
    6d20287 View commit details
    Browse the repository at this point in the history

  4. - fix the import to use import. 

    - add comment explaining the use of `span[aria-hidden="true"]`.
    @worldomonation
    worldomonation committed May 10, 2023
    Configuration menu
    Copy the full SHA
    d6a4f44 View commit details
    Browse the repository at this point in the history

  5. - anchor selectors on a parent selector.

    @worldomonation
    worldomonation committed May 10, 2023
    Configuration menu
    Copy the full SHA
    b6e5c29 View commit details
    Browse the repository at this point in the history

  6. - use the Cover block's resize handle as basis for calculation when r… 

    …esizing the block.
    @worldomonation
    worldomonation committed May 10, 2023
    Configuration menu
    Copy the full SHA
    8b19caf View commit details
    Browse the repository at this point in the history

  7. - remove testing "only"

    @worldomonation
    worldomonation committed May 10, 2023
    Configuration menu
    Copy the full SHA
    f756ede View commit details
    Browse the repository at this point in the history

  8. - check the src repeatedly to contain the fileBasename instead.

    @worldomonation
    worldomonation committed May 10, 2023
    Configuration menu
    Copy the full SHA
    aadc65d View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. - move getBackgroundColorAndOpacity into the ImageBlockUtils POM.

    @worldomonation
    worldomonation committed May 11, 2023
    Configuration menu
    Copy the full SHA
    7897f28 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Rename POM to CoverBlockUtils

    @worldomonation
    worldomonation committed May 12, 2023
    Configuration menu
    Copy the full SHA
    405c709 View commit details
    Browse the repository at this point in the history