Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: add useUpdateEffect to exhaustive-deps lint check #45771

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from
Open

Components: add useUpdateEffect to exhaustive-deps lint check #45771

wants to merge 8 commits into from

Commits on Dec 1, 2022

  1. add useUpdateEffect to exhaustive-deps lint rule

    @chad1008
    chad1008 committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    167827d View commit details
    Browse the repository at this point in the history

  2. add deps and useMemo for asButtonGroup

    @chad1008
    chad1008 committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    c1f675a View commit details
    Browse the repository at this point in the history

  3. udpate deps arrays for as-radio-group.tsx

    @chad1008
    chad1008 committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    bac60b5 View commit details
    Browse the repository at this point in the history

  4. update CHANGELOG

    @chad1008
    chad1008 committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    cc77288 View commit details
    Browse the repository at this point in the history

  5. abstract radioState and setRadioState for cleaner deps

    @chad1008
    chad1008 committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    b230269 View commit details
    Browse the repository at this point in the history

  6. move context into useMemo, and replace getContext with less abstracte… 

    …d variables in the useUpdateEffects
    @chad1008
    chad1008 committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    2556076 View commit details
    Browse the repository at this point in the history

  7. replace useUpdateEffect implementations with useControlledValue

    @chad1008
    chad1008 committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    31e32d5 View commit details
    Browse the repository at this point in the history

  8. remove typecasting on setSelectedValue

    @chad1008
    chad1008 committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    f4a0eca View commit details
    Browse the repository at this point in the history