Fix Nav uncontrolled blocks saving/loading experience #45486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
getdave
force-pushed
the
fix/nav-uncontrolled-blocks-loading-spinner
branch
from
cc89dad to
582f253
Compare
getdave
added
[Type] Regression
|
Size Change: +77 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
MaggieCabrera
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the dual rendering of the uncontrolled blocks alongside the "loading" spinner which can occur when the page list block is converted into a sync'd nav menu.
Only the spinner should render whilst in "saving" mode.
Why?
When converting from uncontrolled inner blocks it was possible to observe the loading spinner sitting alongside the uncontrolled blocks. This looked broken.
The spinner should show on it's own when in a loading state.
How?
I have conditionally rendered either the uncontrolled blocks OR the spinner.
I was concerned about focus loss and a11y but then I noticed that the main Nav block code does much the same and as long as it's wrapped in
TagName(which it is) then the focus should be maintained.Testing Instructions
Screenshots or screencast
Before
Notice the spinner alongside the uncontrolled blocks.
Screen.Capture.on.2022-11-02.at.12-36-03.mp4
### After
Now we have only the spinner showing
Screen.Capture.on.2022-11-02.at.12-33-40.mp4