SpacingSizesControl: Remove UnitControl inline style use #45412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
|
|
Size Change: -15 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Note: There are two other uses of inline styles on a UnitControl. However, those are for the native version of that control and don't require updating now.
Why?
After the changes from #45139, the styles prop is passed to the UnitControl's inner input. This PR removes the only use of inline styles on the web version of
UnitControlwithin Gutenberg.How?
Move the inline style to the unique class name that is already applied to that
UnitControl.Testing Instructions
Screenshots or screencast