Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Character Swap #45355

Merged
merged 1 commit into from
Oct 28, 2022
Merged

[Documentation] Character Swap #45355

merged 1 commit into from
Oct 28, 2022

Conversation

pkorzelius
Copy link
Contributor

@pkorzelius pkorzelius commented Oct 27, 2022

Ellipsis character in the example causes the register_block_type to not register the metadata because the json_decode silently errors with "Malformed UTF-8 characters".

What?

Improving an example in the documentation.

Why?

If you use this json example as a base but do not change the description value (to remove that character) this file is rendered useless. Change could save time for someone else.

How?

Replacing the ellipsis character with 3 periods

Testing Instructions

1 - Copy and pasted example file into block.json (optional - update values to match your setup but leave description value)
2 - Use register_block_type with block.json file path
3 - Be sad that register_block_type did nothing

Screenshots or screencast

Character in the example causes the json_decode in register_block_type to silently error with "Malformed UTF-8 characters".
@codesandbox
Copy link

codesandbox bot commented Oct 27, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 27, 2022
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @pkorzelius! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label Oct 28, 2022
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @pkorzelius!

@Mamaduka Mamaduka merged commit 902c4c6 into WordPress:trunk Oct 28, 2022
@github-actions
Copy link

Congratulations on your first merged pull request, @pkorzelius! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 14.5 milestone Oct 28, 2022
@jeffpaul
Copy link
Member

@pkorzelius checking in to see if you can confirm your WordPress.org username so that you can be properly credited in the WordPress 6.2 release later this month?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants