Components: Remove unnecessary wrappers in stories #45305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
chad1008
reviewed
Oct 26, 2022
There was a problem hiding this comment.
The changes themselves look good to me, but while testing I noticed that ToolsPanel and Card appear to be stretching beyond the width of the viewport:
ToolsPanel:
On Card, this can even result in the story's CTA button to getting cut off:
I'm not sure if this is an indicator that we still need a wrapper, just to set the max to the viewport width, or if this should be addressed in the individual components themselves 🤔
Do you see anything similar @aaronrobertshaw? In case it's browser related, I'm testing in latest Chrome (107.0.5304.62)
|
Actually, scratch that last comment @aaronrobertshaw ...those issues do look like something local to just me. I noticed some other viewport oddities, and after fresh Storybook build this is testing well for me 👍 |
chad1008
approved these changes
Oct 26, 2022
|
Thanks for the review @chad1008. I gave this a quick retest as well and couldn't replicate the problem you initially saw. I'll go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Removes wrappers setting max-widths that are no longer required.
Why?
A new storybook addon was added in #45134 that allows quick toggling of a wrapper that restricts the max width of components to the space available within the WP sidebar. With this we can now remove arbitrary max-width wrappers for component stories.
How?
Removes the max width wrappers in stories for:
#41860 already removes wrappers for the border controls so they aren't addressed in this PR.
Testing Instructions
max-widthormaxWidthwithin any**/stories/**directory.