ColorPalette: Fix transparent checkered background pattern #45295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the
ColorPalette
component's transparent checkered background pattern, so it doesn't become slightly cut off on the right side as outlined in this issue: #42687Why?
For a more visually appealing look.
One thing to note is in Storybook, the background is
248px
wide when set to the WP Sidebar max-width. In the editor, it's228px
wide, so the look is slightly different the checkered pattern is still cut off but in a less awkward way.If we don't want anything cut off, we could change the pattern to
19px
and set the height from64px
to57px
. For one example, so visually, it doesn't change too much.How?
By changing the background size and positioning to
24px
instead of25px
, as suggested by @mirka in the issue mentioned above (#42687).Testing Instructions
Screenshots or screencast
Before:
After: