Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run script loader test #45288

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Run script loader test #45288

merged 1 commit into from
Oct 26, 2022

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Oct 25, 2022

What?

This PR teaches PHPUnit to run script loader tests.

Why?

They were not being executed.

How?

By adding the -test.php suffix.

Testing Instructions

Locally, make sure they are executed: npm run test:unit:php -- --filter WP_Script_Loader_Test.

@oandregal oandregal self-assigned this Oct 25, 2022
@oandregal oandregal added the [Type] Code Quality Issues or PRs that relate to code quality label Oct 25, 2022
@oandregal oandregal requested a review from Mamaduka October 25, 2022 17:03
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, @oandregal!

@oandregal oandregal merged commit 6ee2a49 into trunk Oct 26, 2022
@oandregal oandregal deleted the rename/script-loader-tests branch October 26, 2022 07:35
@github-actions github-actions bot added this to the Gutenberg 14.5 milestone Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants