Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelogs for internal refactorings using inert #45269

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Add changelogs for internal refactorings using inert #45269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
- `TabPanel`: updated to satisfy `react/exhaustive-deps` eslint rule ([#44935](https://github.com/WordPress/gutenberg/pull/44935))
- `ColorPalette`: Convert to TypeScript ([#44632](https://github.com/WordPress/gutenberg/pull/44632)).
- `UnitControl`: Add tests ([#45260](https://github.com/WordPress/gutenberg/pull/45260)).
- `Disabled`: Refactor the component to rely on the HTML `inert` attribute.

## 21.3.0 (2022-10-19)

Expand Down
5 changes: 0 additions & 5 deletions packages/components/src/disabled/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ describe( 'Disabled', () => {
</Disabled>
);

// @ts-ignore
expect( container.firstChild ).toHaveAttribute( 'inert' );
} );

Expand All @@ -40,12 +39,10 @@ describe( 'Disabled', () => {

const { container, rerender } = render( <MaybeDisable /> );

// @ts-ignore
expect( container.firstChild ).toHaveAttribute( 'inert' );

rerender( <MaybeDisable isDisabled={ false } /> );

// @ts-ignore
expect( container.firstChild ).not.toHaveAttribute( 'inert' );
} );

Expand All @@ -58,12 +55,10 @@ describe( 'Disabled', () => {

const { rerender, container } = render( <MaybeDisable /> );

// @ts-ignore
expect( container.firstChild ).toHaveAttribute( 'inert' );

rerender( <MaybeDisable isDisabled={ false } /> );

// @ts-ignore
expect( container.firstChild ).not.toHaveAttribute( 'inert' );
} );

Expand Down
4 changes: 4 additions & 0 deletions packages/compose/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Internal

- `useDisabled`: Refactor the component to rely on the HTML `inert` attribute.

## 5.18.0 (2022-10-19)

## 5.17.0 (2022-10-05)
Expand Down