Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parseQuantityAndUnitFromRawValue tests #45260

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

noisysocks
Copy link
Member

What?

Adds tests for the parseQuantityAndUnitFromRawValue helper in UnitControl. These test cases are the same as the ones for splitNumberAndUnitFromSize that were removed in #44598.

Why?

See #44598 (comment).

How?

Testing Instructions

Screenshots or screencast

@noisysocks noisysocks added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Oct 25, 2022
@noisysocks noisysocks requested a review from ciampo October 25, 2022 01:06
@noisysocks noisysocks requested a review from ajitbohra as a code owner October 25, 2022 01:06
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you! 🚀

(This PR will need a rebase once #45265 gets merged)

@noisysocks noisysocks force-pushed the add/parseQuantityAndUnitFromRawValue-tests branch from 6c2e7ef to b8bd410 Compare October 25, 2022 23:48
@noisysocks noisysocks merged commit 97b2c8c into trunk Oct 26, 2022
@noisysocks noisysocks deleted the add/parseQuantityAndUnitFromRawValue-tests branch October 26, 2022 03:10
@github-actions github-actions bot added this to the Gutenberg 14.5 milestone Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants