Migrate custom taxonomies test to Playwright #45178
Conversation
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @alvitazwar! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
@Mamaduka Can you please help me to review this PR? |
Mamaduka
changed the title
Mamaduka
added
[Type] Automated Testing
There was a problem hiding this comment.
@alvitazwar, let's do a similar refactoring for this test case as we did in #43964.
- Inline helper utility.
- Try to use role selectors whenever possible.
|
@Mamaduka I addressed the feedback regarding the inline approach and use of role selectors. Can you please check? |
|
@Mamaduka Can you please check again? |
|
@alvitazwar, can you rebase this branch on top of the latest trunk? It should resolve the issue with CI. |
* Refactor Site Editor code * Naming consistency
github-actions
bot
added
the
[Status] In Progress
What?
Based on #38570, part of #38851. Migrate custom-taxonomies.test.js
Why?
See #38570 for its background and rationale.
This is split into a new PR for easier review.
How?
See #38570 for the proposed migration steps.
Testing Instructions
npm run test:e2e:playwright /test/e2e/specs/editor/plugins/custom-taxonomies.spec.js
Screenshots or screencast
Screen.Recording.2022-10-21.at.12.11.32.AM.mov