Site Tagline: Fix user permission HTTP errors #45140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mamaduka
requested review from
ntsekouras and
Copons
and removed request for
ajitbohra
Mamaduka
added
[Type] Bug
|
Size Change: +20 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Similar to #45093.
PR fixes user permission HTTP errors generated by the Site Tagline block for non-admin users.
Why?
The editor should check permission before making requests when data isn't available for everyone.
How?
I've updated the selector logic to conditionally fetch data from the settings endpoint or the read-only index based on user permissions.
Testing Instructions
Admin users
The Site Tagline block should work as before.
Non-admin users (e.g. Editor or Author role).